Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firebase_ui_auth): Add "Go Back" button to EmailLinkSignInView #63

Merged
merged 7 commits into from
Aug 24, 2023

Conversation

rstieger
Copy link
Contributor

@rstieger rstieger commented Aug 18, 2023

Description

This PR adds a "Go back" button to EmailLinkSignInView. Other views and screens in firebase_ui_auth have
a similar button already, but EmailLinkSignInView does not, so users can get stuck if they got there by mistake,
mistyped their email address, etc. This button code was copied from SMSCodeInputScreen, so it should be
consistent with other auth flows in the package.

Related Issues

Fixes #81

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • All unit tests pass (melos run test:unit:all doesn't fail).
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Copy link
Member

@lesnitsky lesnitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a unit widget test verifying both scenarios.

@lesnitsky lesnitsky force-pushed the feature/email-link-goback branch 2 times, most recently from 0051219 to 203db8c Compare August 24, 2023 15:52
@lesnitsky lesnitsky merged commit 326fd27 into firebase:main Aug 24, 2023
11 checks passed
@lesnitsky
Copy link
Member

Great job, @rstieger 👍 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Method to back out from EmailLinkSignInScreen in iOS
2 participants