-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(firebase_ui_auth): Add "Go Back" button to EmailLinkSignInView #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesnitsky
requested changes
Aug 22, 2023
packages/firebase_ui_auth/lib/src/views/email_link_sign_in_view.dart
Outdated
Show resolved
Hide resolved
lesnitsky
reviewed
Aug 23, 2023
packages/firebase_ui_auth/lib/src/views/email_link_sign_in_view.dart
Outdated
Show resolved
Hide resolved
lesnitsky
requested changes
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add a unit widget test verifying both scenarios.
lesnitsky
requested changes
Aug 24, 2023
packages/firebase_ui_auth/test/views/email_link_sign_in_view_test.dart
Outdated
Show resolved
Hide resolved
packages/firebase_ui_auth/test/views/email_link_sign_in_view_test.dart
Outdated
Show resolved
Hide resolved
lesnitsky
requested changes
Aug 24, 2023
lesnitsky
force-pushed
the
feature/email-link-goback
branch
2 times, most recently
from
August 24, 2023 15:52
0051219
to
203db8c
Compare
lesnitsky
approved these changes
Aug 24, 2023
Great job, @rstieger 👍 Thank you! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a "Go back" button to EmailLinkSignInView. Other views and screens in firebase_ui_auth have
a similar button already, but EmailLinkSignInView does not, so users can get stuck if they got there by mistake,
mistyped their email address, etc. This button code was copied from SMSCodeInputScreen, so it should be
consistent with other auth flows in the package.
Related Issues
Fixes #81
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.melos run test:unit:all
doesn't fail).Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?